This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Fix volume bindings for docker 1.4.0 #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I understand correctly that your commit disables regular volumes for docker >= 1.4.0? |
|
Well, it seems to be so. I think you should discard this commit. We need to check client api version instead of docker version. |
|
I don't think that any version checking is needed. I think that the handling of binds/volumes has been wrong in the first place. I've tried to improve it with #547. |
|
Closing in favor of #547. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
docker/docker-py#419
moby/moby#9628