Test for circular imports in project #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
approved these changes
Jan 20, 2022
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
ssbarnea
approved these changes
Jan 20, 2022
webknjaz
reviewed
Jan 20, 2022
webknjaz
suggested changes
Jan 20, 2022
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
|
Related: ansible/ansible-runner#969 |
webknjaz
reviewed
Jan 20, 2022
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
webknjaz
approved these changes
Jan 20, 2022
| set( | ||
| chain.from_iterable( | ||
| _discover_path_importables(Path(p), pkg.__name__) | ||
| for p in pkg.__path__ # type: ignore[attr-defined] |
There was a problem hiding this comment.
Check if this is still necessary:
Suggested change
| for p in pkg.__path__ # type: ignore[attr-defined] | |
| for p in pkg.__path__ |
There was a problem hiding this comment.
tests/unit/test_circular_imports.py:36:26: error: Module has no attribute
"__path__" [attr-defined]
for p in pkg.__path__
^
Found 1 error in 1 file (checked 220 source files)
There was a problem hiding this comment.
Looks like updating mypy should fix it: aio-libs/aiohttp@eda8114#diff-6e4d51438e11d25f69b91905d1021363313962f1dc8e251dc1f21580ddc29393L33
|
related: #758 |
|
recheck |
ansible-zuul bot
pushed a commit
that referenced
this pull request
Jan 24, 2022
Change the order of relative imports This modifies the order of relative import statements. Fixes: #780 Prior to this change the order was import .sibling import ..parent import ...grandparent after this change import ...grandparent import ..parent import .sibling The resulting order is the default for isort which decreases the amount of custom configuration within the repo and results in a sorting order starting with "least local" to "most local". This follow on work after #777, which was intended to minimize the changes in the repo related to the cleanup. #779 was also implemented to help detect any issues arising from a change in order. Some conversation and history about the ordering can be found here: PyCQA/isort#417 Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com> Reviewed-by: None <None>
cidrblock
added a commit
to cidrblock/ansible-navigator
that referenced
this pull request
Jan 24, 2022
Change the order of relative imports This modifies the order of relative import statements. Fixes: ansible#780 Prior to this change the order was import .sibling import ..parent import ...grandparent after this change import ...grandparent import ..parent import .sibling The resulting order is the default for isort which decreases the amount of custom configuration within the repo and results in a sorting order starting with "least local" to "most local". This follow on work after ansible#777, which was intended to minimize the changes in the repo related to the cleanup. ansible#779 was also implemented to help detect any issues arising from a change in order. Some conversation and history about the ordering can be found here: PyCQA/isort#417 Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #778
Test for circular imports in all local packages and modules.
This ensures all internal packages can be imported right away without any need to import some other module before doing so.
Related: #777