Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates single select component to add missing resource icon #2595

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AlexSCorey
Copy link
Member

@AlexSCorey AlexSCorey commented Jun 25, 2024

This pr addresses several things:

  • It removes all uses of in awx
  • It removes an unused form component
  • It add missing resource icon for ProjectSelect and for JobTemplateSelect
    Screenshot 2024-06-25 at 4 46 10 PM

It does not add missing resource icon to anything in EDA, HUB, and for AWX --> Inventories. AWX-->Inventories requires an organization, but if the org is deleted the inventory gets deleted also so it won't show up in the select component.

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX AFW Ansible Framework labels Jun 25, 2024
@AlexSCorey AlexSCorey force-pushed the addMissingResourceIcon branch from 58343c0 to 0f60c8e Compare June 26, 2024 16:42
@github-actions github-actions bot added E2E End-to-end testing CCT Component tests labels Jun 26, 2024
@AlexSCorey AlexSCorey force-pushed the addMissingResourceIcon branch 2 times, most recently from cc17a05 to b96b280 Compare June 26, 2024 19:35
@AlexSCorey AlexSCorey marked this pull request as draft June 27, 2024 17:09
@AlexSCorey AlexSCorey force-pushed the addMissingResourceIcon branch from b96b280 to ff5d6bc Compare July 11, 2024 13:46
@AlexSCorey AlexSCorey marked this pull request as ready for review July 11, 2024 13:46
@AlexSCorey AlexSCorey force-pushed the addMissingResourceIcon branch from ff5d6bc to 28cdfc0 Compare July 15, 2024 13:41
…es unused form. Adds missing resource icon to some form selects.
@AlexSCorey AlexSCorey force-pushed the addMissingResourceIcon branch from 28cdfc0 to 06fec1c Compare July 17, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AFW Ansible Framework AWX Label to indicate changes relevant to AWX CCT Component tests E2E End-to-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant