windows: added Ansible.IO c# code to work on paths greater than 260 #43666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
jborean93
force-pushed
the
win_max_path
branch
3 times, most recently
from
86c3ec0 to
b98b544
Compare
ansibot
added
core_review
ryansb
removed
the
needs_triage
jborean93
commented
Aug 8, 2018
| # Test-Path -IsValid failed when the long path prefix is there, we don't want | ||
| # to check this ourselves and just rely on Windows to validate the path when | ||
| # using it | ||
| if ((-not ($value.StartsWith("\\?\"))) -and (-not (Test-Path -Path $value -IsValid))) { |
There was a problem hiding this comment.
I'm wondering whether we should not even run Expand-Environment on the value if it starts with \\?\ to allow people to force a file/dir name with a value that's like an env var.
ansibot
added
needs_revision
|
I've restarted the failing CI job multiple times, but it keeps coming back unstable: https://app.shippable.com/github/ansible/ansible/runs/77931/12/tests |
mattclay
added
the
ci_verified
|
@mattclay thanks, looks like there's still an issue with async. Will look into it. |
jborean93
force-pushed
the
win_max_path
branch
from
a1e4d39 to
a26c0f8
Compare
ansibot
removed
ci_verified
ansibot
added
the
core_review
jborean93
force-pushed
the
win_max_path
branch
from
a26c0f8 to
414aad2
Compare
ansibot
added
needs_ci
jborean93
force-pushed
the
win_max_path
branch
from
414aad2 to
d1d90f9
Compare
ansibot
added
the
stale_ci
ansibot
added
needs_rebase
|
cc @if-meaton |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds the namespace
Ansible.IOto theAnsible.ModuleUtils.FileUtilthat allows modules to interact with paths that exceeds MAX_PATH (~260 chars). This namespace is designed to replicate the functionality ofSystem.IO.Directory/DirectoryInfo/File/FileInfo/Pathbut also to add support for the following;\\?\prefixCompress()andDecompress()methods to enable the toggling of the Compress attributeFurther changes to this PR are to LinkUtil which changes;
SeBackupPrivilegewhen required instead of doing it globallyFirst part to achieve #43060.
ISSUE TYPE
COMPONENT NAME
lib/ansible/module_utils/powershell/Ansible.ModuleUtils.FileUtil.psm1
lib/ansible/module_utils/powershell/Ansible.ModuleUtils.LinkUtil.psm1
win_stat
win_command
win_shell
win_wait_for
ANSIBLE VERSION
ADDITIONAL INFORMATION
There is a lot of code in the Ansible.ModuleUtils.FileUtil.psm1 is slightly modified from https://github.com/dotnet/corefx which is licensed under the MIT license. When doing some testing against devel, the
win_stattests only took an extra 1-3 seconds so the extra code does not seem to slow anything down dramatically.