Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for connection_name on multi-source replication #46243

Closed
wants to merge 4 commits into from
Closed

support for connection_name on multi-source replication #46243

wants to merge 4 commits into from

Conversation

diegobill
Copy link

@diegobill diegobill commented Sep 28, 2018 •
edited by Akasurde
Loading

(https://mariadb.com/kb/en/library/multi-source-replication/)

SUMMARY

support for connection_name on multi-source replication (https://mariadb.com/kb/en/library/multi-source-replication/)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module mysql mysql_replication

ANSIBLE VERSION
ansible 2.8.0.dev0
  config file = None
  configured module search path = ['/home/felix/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/felix/workspace/tapweb.cgi/.env/lib/python3.5/site-packages/ansible
  executable location = /home/felix/workspace/tapweb.cgi/.env/bin/ansible
  python version = 3.5.2 (default, Nov 23 2017, 16:37:01) [GCC 5.4.0 20160609]

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 28, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 28, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/database/mysql/mysql_replication.py:0:0: E322 "connection_name" is listed in the argument_spec, but not documented in the module

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 28, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 28, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 28, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/database/mysql/mysql_replication.py:0:0: E309 version_added for new option (connection_name) should be 2.8. Currently 0.0

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 28, 2018
@Akasurde Akasurde changed the title support for connection_name on multi-source replication (https://mari… support for connection_name on multi-source replication Sep 28, 2018
bcoca
bcoca requested changes Oct 1, 2018
View reviewed changes
lib/ansible/modules/database/mysql/mysql_replication.py
@@ -88,6 +88,9 @@
description:
- does the host uses GTID based replication or not
version_added: "2.0"
connection_name:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing version_added

@bcoca bcoca removed needs_triage Needs a first human triage before being processed. python3 labels Oct 1, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 3, 2018

@diegobill this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html support:community This issue/PR relates to code supported by the Ansible community. and removed ci_verified Changes made in this PR are causing tests to fail. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 3, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 3, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/database/mysql/mysql_replication.py:0:0: E309 version_added for new option (connection_name) should be 2.8. Currently 0.0

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 3, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/database/mysql/mysql_replication.py:0:0: E309 version_added for new option (connection_name) should be 2.8. Currently 0.0

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Oct 3, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 12, 2018
@ansibot ansibot removed the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Nov 10, 2018
@ansibot ansibot added the test This PR relates to tests. label Feb 3, 2019
@ansibot ansibot added the database Database category label Feb 19, 2019
@CyberBLN
Copy link

CyberBLN commented Mar 3, 2019

@diegobill Can you please rebase your branch to get it merged into official repo? Thank you :)

@Andersson007
Copy link
Contributor

@diegobill , hello, thank you for the pr
I've recently added integration tests for mariadb from scratch test/integration/targets/mariadb_replication/tasks/.
Now it is possible to test mysql_replication module.
So, could you please

  1. add tests for this pr by separate file and including it to test/integration/targets/mariadb_replication/tasks/main.yml
  2. An example of using this parameter to Example block

After that i review it.
(Would be cool to get a feedback ASAP, i can wait a couple of days - no more :) , then, if you're busy, i could rewrite it, no problem)
Thank you!

@Andersson007 Andersson007 mentioned this pull request Oct 8, 2019
Merged
@Andersson007
Copy link
Contributor

@gundalow , please, close this via #63229

@gundalow
Copy link
Contributor

gundalow commented Oct 8, 2019

resolved_by_pr: 63229

@gundalow gundalow closed this Oct 8, 2019
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca requested changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 ci_verified Changes made in this PR are causing tests to fail. database Database category feature This issue/PR relates to a feature request. merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. mysql needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@diegobill @ansibot @CyberBLN @Andersson007 @gundalow @bcoca @dagwieers