Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql modules: fix sanity issues #67046

Merged
merged 3 commits into from
Feb 6, 2020
Merged

postgresql modules: fix sanity issues #67046

merged 3 commits into from
Feb 6, 2020

Conversation

Andersson007
Copy link
Contributor

SUMMARY

postgresql modules: fix sanity issues

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/database/postgresql/postgresql_copy.py
...

@ansibot
Copy link
Contributor

ansibot commented Feb 3, 2020

cc @Dorn- @amenonsen @andytom @antoinell @archf @jbscalia @jensdepuydt @jscalia @kostiantyn-nemchenko @matburt @mattclay @nerzhul @sebasmannem @tcraxs @tremble @wrouesnel
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. database Database category module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Feb 3, 2020
@Andersson007
Copy link
Contributor Author

ready_for_review

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 3, 2020
@Andersson007
Copy link
Contributor Author

ready_for_review

@felixfontein
Copy link
Contributor

It might make sense to add a changelog fragment for the modules where the behavior changes (i.e. required=True is added), informing the user that error checking has been improved.

@Andersson007
Copy link
Contributor Author

Great suggestion, thanks! It should be there. Will add

@Andersson007
Copy link
Contributor Author

i haven't added a changelog fragment for postgresql_subscription because it's not been released (coming in 2.10)

@felixfontein
Copy link
Contributor

What about postgresql_tablespace? That was added for 2.8 and now has a parameter that is required.

@Andersson007
Copy link
Contributor Author

Done, thank you for pointing it out! (i slept for 3 hours, better not to code in such a condition:)

@Andersson007
Copy link
Contributor Author

@felixfontein if it is ok now, feel free to merge:)

@felixfontein felixfontein merged commit 637eed5 into ansible:devel Feb 6, 2020
@Andersson007
Copy link
Contributor Author

@felixfontein thanks for reviewing!

@ansible ansible locked and limited conversation to collaborators Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. database Database category module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andersson007 @ansibot @felixfontein