modules/dnf: Substitute variables in DNF cache path #80094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.15
bug
This comment was marked as outdated.
This comment was marked as outdated.
ansibot
added
the
needs_revision
BenoitKnecht
force-pushed
the
dnf-expand-cachedir
branch
from
20d0c69 to
ebeb248
Compare
ansibot
added
needs_revision
BenoitKnecht
force-pushed
the
dnf-expand-cachedir
branch
from
ebeb248 to
905f743
Compare
ansibot
added
needs_revision
mattclay
added
ci_verified
sivel
reviewed
Feb 27, 2023
BenoitKnecht
force-pushed
the
dnf-expand-cachedir
branch
from
905f743 to
2fc487b
Compare
ansibot
added
needs_revision
This comment was marked as outdated.
This comment was marked as outdated.
ansibot
added
test
BenoitKnecht
force-pushed
the
dnf-expand-cachedir
branch
from
b1c7134 to
197e1a6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ansibot
added
the
stale_ci
jborean93
requested changes
Jul 26, 2023
There was a problem hiding this comment.
For the changes here we will need a changelog fragment for this PR which is documented here https://docs.ansible.com/ansible/latest/community/development_process.html#creating-changelog-fragments. We would also look at adding some integration tests for this scenario under https://github.com/ansible/ansible/tree/devel/test/integration/targets/dnf. The integration tests might be a bit harder to setup but we can certainly work through them if you have any questions.
ansibot
added
the
needs_revision
The cache directory can be specified with variables that are expanded by DNF, e.g. ``` cachedir=/var/cache/yum/$basearch/$releasever ``` But the `dnf` module would use that path literally, instead of replacing `$basearch` and `$releasever` with their values. This commit ensures that variables in `cachedir` are properly substituted. Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
Now that the `dnf` module uses `libdnf`, `mypy` returns the following error on `lib/ansible/modules/dnf.py`: ``` import: Cannot find implementation or library stub for module named "libdnf" ``` This commit makes `mypy` ignore missing imports for `libdnf`. Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
Akasurde
force-pushed
the
dnf-expand-cachedir
branch
from
197e1a6 to
607750d
Compare
ansibot
removed
the
stale_ci
jborean93
approved these changes
Apr 9, 2024
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Apr 10, 2024
In ansible#80094 support for var substitution for cachedir was added but there are more options that should be supported. Using an API for prepend_installroot which should be done anyway provide that feature so use that. In addition, perform the operation once all substitutes are in place (releasever as well).
mkrizek
added a commit
that referenced
this pull request
Apr 12, 2024
In #80094 support for var substitution for cachedir was added but there are more options that should be supported. Using an API for prepend_installroot which should be done anyway provide that feature so use that. In addition, perform the operation once all substitutes are in place (releasever as well).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The cache directory can be specified with variables that are expanded by DNF, e.g.
But the
dnfmodule would use that path literally, instead of replacing$basearchand$releaseverwith their values.This commit ensures that variables in
cachedirare properly substituted.ISSUE TYPE
COMPONENT NAME
dnfADDITIONAL INFORMATION
To reproduce the issue, set
in
/etc/dnf/dnf.confand use thednfmodule to install a package. On the target system, Ansible will create a directory called/var/cache/yum/$basearch/$releasever, instead of/var/cache/yum/x86_64/8for instance.