Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Upgrade Faraday to minimum of v0.13 for IPv6 support #97

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

bdunne
Copy link
Contributor

@bdunne bdunne commented Aug 16, 2017

See lostisland/faraday#714 for more details

@syncrou Please review.
This will conflict with manageiq-api-client Fixed by ManageIQ/manageiq-api-client#71

@miq-bot
Copy link
Collaborator

miq-bot commented Aug 16, 2017

Checked commit bdunne@7e82aa8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Contributor

@syncrou syncrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@bdunne bdunne merged commit 6b57065 into ansible:master Aug 17, 2017
@bdunne bdunne deleted the upgrade_faraday branch August 17, 2017 20:44
@Glutexo
Copy link
Contributor

Glutexo commented Mar 28, 2018

This breaks compatibility with current manageiq master. manageiq-api-client requires faraday (~> 0.9.2).

Bundler could not find compatible versions for gem "faraday":
  In Gemfile:
    ansible_tower_client was resolved to 0.12.2, which depends on
      faraday (~> 0.13)

    manageiq-api-client (~> 0.1.0) was resolved to 0.1.1, which depends on
      faraday (~> 0.9.2)

@bdunne
Copy link
Contributor Author

bdunne commented Mar 28, 2018

@Glutexo Looks fine for me.

manageiq (master)$ bundle show ansible_tower_client
/home/bdunne/.gem/ruby/2.4.3/gems/ansible_tower_client-0.12.2
manageiq (master)$ bundle show manageiq-api-client
/home/bdunne/.gem/ruby/2.4.3/gems/manageiq-api-client-0.3.0
manageiq (master)$ bundle show faraday
/home/bdunne/.gem/ruby/2.4.3/gems/faraday-0.9.2

@Glutexo
Copy link
Contributor

Glutexo commented Mar 29, 2018

Oh, I was too hasty with the conclusion where the problem lies. ansible_tower_client’s faraday-0.13 matches manageiq-api-client’s ~> 0.9 just fine. As @jrafanie pointed out, prometheus-alert-buffer-client and xclarity_client dependencies are the culprits as both require ~> 0.9.2.

See hee all MIQ’s faraday dependencies: https://gist.github.com/Glutexo/0caa78980a09fd8fdaecb1b1c521cba0#gistcomment-2394617

So just please keep that in mind before releasing a new version with this patch as manageiq would then become unbundlable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants