Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deprecated collections path variable #1648

Merged

Conversation

justsomescripts
Copy link
Contributor

SUMMARY

This PR replaces the ANSIBLE_COLLECTIONS_PATHS environment variable in AWX Web that has been deprecated and replaced by ANSIBLE_COLLECTIONS_PATH (available since Ansible 2.10).

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
ADDITIONAL INFORMATION

Warning message when executing jobs

[DEPRECATION WARNING]: ANSIBLE_COLLECTIONS_PATHS option, does not fit var 
naming standard, use the singular form ANSIBLE_COLLECTIONS_PATH instead. This 
feature will be removed from ansible-core in version 2.19. Deprecation warnings
can be disabled by setting deprecation_warnings=False in ansible.cfg.

https://docs.ansible.com/ansible/latest/reference_appendices/config.html#envvar-ANSIBLE_COLLECTIONS_PATHS

@shanemcd
Copy link
Member

shanemcd commented Dec 1, 2023

I think this is dead code and should get deleted. Pretty sure this is what needs to change:

https://github.com/ansible/awx/blob/3b4d95633e5302c6b67903f7b9e737d264c154fd/awx/main/tasks/jobs.py#L928

@shanemcd
Copy link
Member

shanemcd commented Dec 1, 2023

Actually... it looks like we already accounted for the name change:

https://github.com/ansible/awx/blob/3b4d95633e5302c6b67903f7b9e737d264c154fd/awx/main/tasks/jobs.py#L930

I think we should probably just delete this line of code from the operator configmap.

@justsomescripts
Copy link
Contributor Author

Makes sense. thanks for clarifying @shanemcd 👍

I think we should probably just delete this line of code from the operator configmap.

I'll update the PR to just remove this line then so it's searching for ANSIBLE_COLLECTIONS_PATHS in this repo is less confusing.

@justsomescripts justsomescripts force-pushed the devel-collections-path-fix branch from 3f29531 to bf75914 Compare December 4, 2023 08:49
@TheRealHaoLiu TheRealHaoLiu enabled auto-merge (squash) December 6, 2023 19:17
@TheRealHaoLiu TheRealHaoLiu merged commit ef17865 into ansible:devel Dec 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants