Always check and wait for a restore pg_restore to finish #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rooftopcellist
force-pushed
the
restore-race-with-installer
branch
2 times, most recently
from
9c5b581 to
719e5fc
Compare
rooftopcellist
force-pushed
the
restore-race-with-installer
branch
from
719e5fc to
74a4c02
Compare
TheRealHaoLiu
approved these changes
Dec 1, 2023
This was referenced Dec 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If the database is big enough in a backup, when restoring it, the restore role's pg_restore command can sometimes be at odds with the installer role of the new AWX instance (specifically when I tries to run migrations). This can result in some unpleasant db errors.
This resolves that by checking for the presence of an AWXRestore object with a deployment_name that matches, and waiting for it to complete before continuing the installer role.
ISSUE TYPE