Skip to content

Check if image_pull_secrets variable is defined #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2022
Merged

Check if image_pull_secrets variable is defined #865

merged 1 commit into from
Apr 11, 2022

Conversation

rooftopcellist
Copy link
Member

@rooftopcellist rooftopcellist commented Apr 11, 2022 •
edited
Loading

  • Do not attempt to backup secret if none are defined

This is the PR that introduced the issue: #860

@rooftopcellist
Check if image_pull_secrets variable is defined
4af82ab 
  * Do not attempt to backup secret if none are defined
@rooftopcellist
Copy link
Member Author

I just tested a backup without image_pull_secrets specified on the awx spec and it worked as expected. Restores worked after removing the old awx instance. It turns out there is a port conflict when using NodePort, this is an unrelated issue though due to #815. It is not an issue when using Routes.

@rooftopcellist rooftopcellist merged commit 1b41d94 into ansible:devel Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zokormazo Zokormazo Zokormazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rooftopcellist @Zokormazo