Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added idle_timeout setting to job settings #10906

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Added idle_timeout setting to job settings #10906

merged 3 commits into from
Oct 13, 2021

Conversation

oweel
Copy link
Contributor

@oweel oweel commented Aug 18, 2021

SUMMARY

#10829

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • API
  • UI
AWX VERSION
19.2.2
ADDITIONAL INFORMATION

@tiagodread tiagodread requested review from nixocio and shanemcd August 18, 2021 17:24
nixocio
nixocio approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@nixocio nixocio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI changes are sane. Thanks @oweel.

jakemcdermott
jakemcdermott reviewed Aug 18, 2021
View reviewed changes
awx/main/conf.py Outdated
'DEFAULT_JOB_IDLE_TIMEOUT',
field_class=fields.IntegerField,
min_value=0,
default=600,
Copy link
Contributor

@jakemcdermott jakemcdermott Aug 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also the default value used by runner for idle_timeout?

Will the behavior of preexisting job templates be impacted after upgrading?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakemcdermott thank you for your feedback!
Yes, you are right. I set default value is 0 for prevent overriding idle_timeout in preexisting job templates.

@oweel oweel force-pushed the 10829-idle_timeout_setting branch from 4abb3a3 to abecf6d Compare August 19, 2021 09:48
@oweel oweel force-pushed the 10829-idle_timeout_setting branch from abecf6d to 530977d Compare August 19, 2021 10:18
@felipe4334
Copy link

@shanemcd It would be great if you could please review this pull request.

@felipe4334
Copy link

Hello @shanemcd

@felipe4334
Copy link

@nixocio Can this please be merged?

@shanemcd shanemcd merged commit 60a357e into ansible:devel Oct 13, 2021
@felipe4334
Copy link

felipe4334 commented Dec 10, 2021 •
edited
Loading

@oweel it looks like idle_timeout might not be working too well.

Even though idle_timeout is set to 0 its still timing out in 5-6 minutes.
image

image

  • pause:
    minutes: 20

If idle_timeout is set to something like 10 seconds then it works.
image
image

And if idle_timeout is set to like 9999 it will still timeout in 5-6 minutes:
image
image

@felipe4334 felipe4334 mentioned this pull request Dec 13, 2021
Closed
@felipe4334 felipe4334 mentioned this pull request Dec 20, 2021
Open
3 tasks
@shanemcd shanemcd mentioned this pull request Jan 31, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemcdermott jakemcdermott jakemcdermott left review comments

@nixocio nixocio nixocio approved these changes

@shanemcd shanemcd Awaiting requested review from shanemcd

Assignees
No one assigned
Labels
component:api component:ui type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@oweel @felipe4334 @nixocio @jakemcdermott @shanemcd @rebeccahhh @tiagodread @awxbot