Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user role association in access modal #12123

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Fix user role association in access modal #12123

merged 1 commit into from
Apr 27, 2022

Conversation

marshmalien
Copy link
Member

SUMMARY

Resolves #12109

  • Fix bug where the UI would create an exponential amount of user-role association requests based on the number of users selected
  • Refactor to use useSelected hook
  • Add unit test to assert the correct number of requests made

roles

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • UI

@akus062381 akus062381 self-assigned this Apr 27, 2022
@marshmalien marshmalien requested a review from keithjgrant April 27, 2022 20:48
@akus062381 akus062381 merged commit b885fc2 into ansible:devel Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akus062381 akus062381 akus062381 approved these changes

@keithjgrant keithjgrant keithjgrant approved these changes

@AlexSCorey AlexSCorey Awaiting requested review from AlexSCorey

@mabashian mabashian Awaiting requested review from mabashian

Assignees

@akus062381 akus062381

Labels
component:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Random roles assigned to users
3 participants
@marshmalien @keithjgrant @akus062381