Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the dashboard job summary endpoint #13924

Merged

Conversation

jamestalton
Copy link
Contributor

@jamestalton jamestalton commented Apr 27, 2023

SUMMARY

Enhance the dashboard job summary endpoint to contain canceled and error job counts.

Jobs have 4 completion states successful, failed, canceled, and error.

The dashboard api endpoint only gives successful and failed, which makes the user think there is something wrong with the dashboard because jobs with an error status do not show up. This PR adds those counts to the dashboard API.

We see this on the new dashboard, where the recent jobs card shows errors but the chart shows none.

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • API

This PR: ansible/ansible-ui#477
Adds support to the Ansible-UI to use the updated API payload.

This is an example screenshot of what the customer sees without this PR. Notice no red in the graph. :(
Screenshot 2023-04-27 at 8 59 32 AM

@jamestalton
Copy link
Contributor Author

jamestalton commented May 3, 2023

jmack slack comment
Looks good. The query filtering and data extraction operations are the same code repeated so that could probably be consolidated since were doing it four times now

@jamestalton
Copy link
Contributor Author

from alancoding in slack
Strictly from the API side, we should expand tests to check the new fields you're adding, we probably already have some dashboard tests for counts, so I think it's unlikely this would be new tests, just expanding what's there
well I'm coming up with a surprising shortage of dashboard tests...
Since this gives global counts, I think the best format for the test would be an API unit test for the view.

@shanemcd
Copy link
Member

shanemcd commented May 3, 2023

Let's make sure those 3 merge commits don't make their way into devel. Either rebase this manually prior to, or choose the squash option when clicking the merge button.

@TheRealHaoLiu TheRealHaoLiu force-pushed the Enhance-the-dashboard-job-summary branch from 241b3d9 to 635661a Compare February 15, 2024 15:52
…ror job counts

Signed-off-by: James Talton <jtalton@redhat.com>
@dmzoneill dmzoneill force-pushed the Enhance-the-dashboard-job-summary branch from 635661a to 1b5d757 Compare February 21, 2024 13:41
@dmzoneill dmzoneill enabled auto-merge (rebase) February 21, 2024 14:00
@dmzoneill dmzoneill merged commit 06ad32e into ansible:devel Feb 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants