Only block commits if black fails for certain paths #14531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-westcott-iv
approved these changes
Oct 5, 2023
|
Do you want to change the pre-commit hook as well? |
What does this mean? |
It means I was in a meeting when I reviewed this and totally spaced, thinking that you were modifying a check in the GH actions. But clearly, you are already modifying the pre-commit hook, lol. My bad 🤦♀️ |
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Connect #13241
This solution isn't "perfect". It doesn't reuse the ignore list in
pyproject.toml, but this would be very hard to make work with the overall structure we have. I don't want to let the best be the enemy of the good, and this seems pretty good to me. This doesn't change how the checks work, and I don't foresee any problems with it.ISSUE TYPE
COMPONENT NAME