Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update teams.rst #14539

Merged
merged 2 commits into from
Oct 17, 2023
Merged

docs: Update teams.rst #14539

merged 2 commits into from
Oct 17, 2023

Conversation

ro4i7
Copy link
Contributor

@ro4i7 ro4i7 commented Oct 3, 2023 •
edited by tvo318
Loading

SUMMARY

solved: #14520
solved under hacktoberfest 2023

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
  • UI
  • Collection
  • CLI
  • Docs
  • Other
AWX VERSION
ADDITIONAL INFORMATION

@ro4i7
Copy link
Contributor Author

ro4i7 commented Oct 4, 2023

@tvo318 please check this

@tvo318 tvo318 added the Hacktoberfest Issues tagged for Hacktoberfest label Oct 4, 2023
tvo318
tvo318 requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@tvo318 tvo318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few alt text revisions... Also, please amend your final commit to do the DCO signoff per the Contributor's Guide guidelines? To do this:

  1. Do a git commit --signoff
  2. Then push the new commits to your branch

Thanks again for your valuable contributions!

docs/docsite/rst/userguide/teams.rst Outdated Show resolved Hide resolved
docs/docsite/rst/userguide/teams.rst Outdated Show resolved Hide resolved
docs/docsite/rst/userguide/teams.rst Outdated Show resolved Hide resolved
docs/docsite/rst/userguide/teams.rst Outdated Show resolved Hide resolved
docs/docsite/rst/userguide/teams.rst Outdated Show resolved Hide resolved
docs/docsite/rst/userguide/teams.rst Outdated Show resolved Hide resolved
docs/docsite/rst/userguide/teams.rst Show resolved Hide resolved
docs/docsite/rst/userguide/teams.rst Outdated Show resolved Hide resolved
docs/docsite/rst/userguide/teams.rst Outdated Show resolved Hide resolved
@tvo318 tvo318 self-requested a review October 9, 2023 22:52
@tvo318
Copy link
Member

tvo318 commented Oct 9, 2023

@ro4i7 - can you address these changes, please? If not I'll update your PR with my own changes. thanks!

@oraNod oraNod self-requested a review October 10, 2023 10:35
tvo318
tvo318 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@tvo318 tvo318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ro4i7 for your contributions. I've added my own commits to yours and went ahead and approved it!

@tvo318 tvo318 enabled auto-merge (squash) October 16, 2023 23:43
@tvo318 tvo318 merged commit 6040e44 into ansible:devel Oct 17, 2023
ro4i7 added a commit to ro4i7/awx that referenced this pull request Oct 17, 2023
@ro4i7
Revert "docs: Update teams.rst (ansible#14539)"
13b3aa2 
This reverts commit 6040e44.
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
@ro4i7 @tvo318 @djyasin
docs: Update teams.rst (ansible#14539)
84f868b 
Co-authored-by: TVo <thavo@redhat.com>
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
@ro4i7 @tvo318 @djyasin
docs: Update teams.rst (ansible#14539)
e096274 
Co-authored-by: TVo <thavo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvo318 tvo318 tvo318 approved these changes

@oraNod oraNod Awaiting requested review from oraNod

Assignees
No one assigned
Labels
community component:docs Hacktoberfest Issues tagged for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ro4i7 @tvo318