Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAP-13369 Python 3.9 -> 3.11 upgrade #14771

Merged
merged 12 commits into from
Mar 13, 2024
Merged

AAP-13369 Python 3.9 -> 3.11 upgrade #14771

merged 12 commits into from
Mar 13, 2024

Conversation

dmzoneill
Copy link
Member

@dmzoneill dmzoneill commented Jan 16, 2024

SUMMARY
  • This updates python version from 3.9 to 3.11

related #13820

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • n/a
AWX VERSION
  • n/a
ADDITIONAL INFORMATION
  • n/a

@dmzoneill dmzoneill marked this pull request as draft January 16, 2024 16:57
@AlanCoding
Copy link
Member

Note that there are some prior comments at #14257 which this replaces

@dmzoneill dmzoneill closed this Jan 17, 2024
@dmzoneill dmzoneill reopened this Jan 17, 2024
@dmzoneill dmzoneill force-pushed the AAP13369 branch 5 times, most recently from 8886d0e to 696632e Compare January 17, 2024 12:39
Copy link
Contributor

@jjwatt jjwatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes are important:

  • don't use update-alternatives
  • don't refer to the bin as just python3; don't make it even more implicit than it already is

@dmzoneill dmzoneill force-pushed the AAP13369 branch 8 times, most recently from bab640b to 82766cd Compare January 17, 2024 17:43
@jjwatt
Copy link
Contributor

jjwatt commented Jan 18, 2024

I edited a couple comments. Added a small optional change:
optional nit: github supports this, iirc:
RUN pip3 install black git+https://github.com/coderanger/supervisor-stdout .git@973ba19967cdaf46d9c1634d1675fc65b9574f6e
If you want to try that, my OCD will be a little happier :)
NOTE: speed boost, too! GitHub takes advantage of those shas to bundle/compress and cache.

@dmzoneill dmzoneill force-pushed the AAP13369 branch 3 times, most recently from 51c1689 to 44e2b0d Compare January 18, 2024 13:46
@dmzoneill
Copy link
Member Author

bash-5.1$ pgrep -u 1000 | while read a; do echo -n "$a "; readlink /proc/$a/exe; done | grep python
248 /usr/bin/python3.11
249 /usr/bin/python3.11
250 /usr/bin/python3.11
251 /usr/bin/python3.11
252 /usr/bin/python3.11
257 /usr/bin/python3.11
261 /usr/bin/python3.11
263 /usr/bin/python3.11
264 /usr/bin/python3.11
403 /usr/bin/python3.11
484 485 486 487 /usr/bin/python3.11
494 /usr/bin/python3.11
496 /usr/bin/python3.11
498 /usr/bin/python3.11
505 /usr/bin/python3.11
506 /usr/bin/python3.11
507 /usr/bin/python3.11
508 /usr/bin/python3.11

jjwatt
jjwatt previously approved these changes Jan 18, 2024
Copy link
Contributor

@jjwatt jjwatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please update the doc and/or drop that patch & do it in a followup.

@dmzoneill dmzoneill changed the title Draft: AAP-13369 Python 3.9 -> 3.11 upgrade AAP-13369 Python 3.9 -> 3.11 upgrade Jan 19, 2024
@dmzoneill dmzoneill marked this pull request as ready for review January 19, 2024 12:13
@dmzoneill dmzoneill force-pushed the AAP13369 branch 2 times, most recently from 328977f to bbefee1 Compare January 19, 2024 12:23
@CFSNM CFSNM marked this pull request as ready for review March 5, 2024 11:11
CFSNM
CFSNM previously approved these changes Mar 5, 2024
@dmzoneill dmzoneill marked this pull request as draft March 5, 2024 13:04
@dmzoneill dmzoneill dismissed CFSNM’s stale review March 5, 2024 13:22

Chunk of CI errors, here, need confirmation prior to approval

@CFSNM CFSNM self-requested a review March 5, 2024 19:05
@CFSNM CFSNM force-pushed the AAP13369 branch 2 times, most recently from 672ff84 to 19350b8 Compare March 5, 2024 19:20
@dmzoneill dmzoneill marked this pull request as ready for review March 6, 2024 08:14
@CFSNM CFSNM merged commit 12843ec into devel Mar 13, 2024
21 checks passed
@CFSNM CFSNM deleted the AAP13369 branch March 13, 2024 13:41
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
* Python 3.9 -> 3.11 upgrade

* Test: updating azure-keyvault to 4.2.0

* Revert "Test: updating azure-keyvault to 4.2.0"

This reverts commit cf0b836.

* Test: updating azure-keyvault to latest and adding azure-identity

* Fix licenses

* Adding new licenses

* Revert "Fix licenses"

This reverts commit da38769.

* Fixing dependencies

* Test: updating azure-keyvault to 4.2.0

* Fix licenses

* Revert "Fix licenses"

This reverts commit da38769.

* Fixing dependencies

---------

Co-authored-by: César Francisco San Nicolás Martínez <csannico@redhat.com>
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
* Python 3.9 -> 3.11 upgrade

* Test: updating azure-keyvault to 4.2.0

* Revert "Test: updating azure-keyvault to 4.2.0"

This reverts commit cf0b836.

* Test: updating azure-keyvault to latest and adding azure-identity

* Fix licenses

* Adding new licenses

* Revert "Fix licenses"

This reverts commit da38769.

* Fixing dependencies

* Test: updating azure-keyvault to 4.2.0

* Fix licenses

* Revert "Fix licenses"

This reverts commit da38769.

* Fixing dependencies

---------

Co-authored-by: César Francisco San Nicolás Martínez <csannico@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api component:cli dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants