[Make] remove the ldap volume when cleaning all volumes #14874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmzoneill
force-pushed
the
remove_ldap_volume
branch
from
9e5779a to
e3243ad
Compare
dmzoneill
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
while working on #14777 I ran into an issue where the ldif was templated correctly but was not applied correct. come to find out, even after what I thought were fresh installs, the ldap volume was still laying around.
this PR adds it to our
make docker-clean-volumestarget.ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION