-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make JWT the first auth class and default #14932
Conversation
* No harm in adding it to the list. If a JWT auth header is provided, then process it (valid or not). If a JWT is not provided, move on to the next auth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this out, if no JWT header, everything else (basic, session, token) works fine. So should not regress
I don't know if specific to our installation, is a bit custom (but we didn't touch source code). But with LDAP (didn't test without) since 24.3.1 (and so since this PR) (everything works fine on 23.8.2) we get error on logging page and impossible to log in. Since that Dump of `request` object
Regarding the error, I don't think is related to LDAP. But do you have any idea if something missing on my installation to explain that failure? |
SUMMARY
No harm in adding it to the list. If a JWT auth header is provided, then process it (valid or not). If a JWT is not provided, move on to the next auth.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION