Fix and test data migration error from DAB RBAC #15138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
fosterseth
approved these changes
Apr 24, 2024
|
First version had a failure with
and that was just due to creating the organization object the test needs. I saw this failure locally, and I expect to see it in the checks here. I made a change to the test and am trying to verify that locally before pushing, but it seems these tests can take on the order of ~10 minutes. |
AlanCoding
force-pushed
the
fix_rbac_migration
branch
from
99baf14 to
f971ac3
Compare
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
* Fix and test data migration error from DAB RBAC * Fix up migration test * Fix custom method bug * Fix another fat fingered bug
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
* Fix and test data migration error from DAB RBAC * Fix up migration test * Fix custom method bug * Fix another fat fingered bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I can explain how this bug was introduced...
One of the latest things done before merging the prior PR that integrated the RBAC app from the DAB library was that the
RoleDefinitionnames were changed to a new naming convention. As a part of this, we didn't want to use all-lowercase names like "jobtemplate", so I calledmodel_classon theContentTypeobject.Testing this with the "current" unit tests, you would just pass in the "current" apps, which would have that method. However, with historical migrations, you're using partial models that don't have such methods available.
Thus, #15137
ISSUE TYPE
COMPONENT NAME