Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix success_url_allowed_hosts set instantiation #15196

Merged
merged 1 commit into from
May 16, 2024

Conversation

manstis
Copy link
Contributor

@manstis manstis commented May 16, 2024

SUMMARY

Further to #15148

This PR fixes parsing of the injected setting value.

I've tested with a locally built AWX image deployed to OpenShift and verified various scenarios now work correctly.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
AWX VERSION
awx: 24.3.2.dev9+g0649fe7e8d
ADDITIONAL INFORMATION

The injection of spec.extra_settings into Django's settings was adding the value as a set of characters.

This PR corrects handling of the setting to use a set of parsed, comma separated, values.

@jessicamack jessicamack self-requested a review May 16, 2024 14:37
@rooftopcellist rooftopcellist merged commit d4bdaad into ansible:devel May 16, 2024
22 checks passed
djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024
Co-authored-by: Michael Anstis <manstis@redhat.com>
djyasin pushed a commit to djyasin/awx that referenced this pull request Nov 11, 2024
Co-authored-by: Michael Anstis <manstis@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants