Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Generate separate requirements files for python2 and python3 ansible venvs #3550

Closed
wants to merge 2 commits into from
Closed

[WIP] Generate separate requirements files for python2 and python3 ansible venvs #3550

wants to merge 2 commits into from

Conversation

wenottingham
Copy link
Contributor

SUMMARY

Rationale: I don't trust dependencies to always resolve the same in a way that can be versioned around without making the files very ugly.

ISSUE TYPE
  • Feature Pull Request
  • Bugfix Pull Request

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@sumkincpp
Copy link
Contributor

sumkincpp commented Mar 29, 2019 •
edited
Loading

Hi @wenottingham,
Might be useful - Since version 6.0 pip supports conditional python versioning
https://pip.readthedocs.io/en/stable/reference/pip_install/#requirement-specifiers
But of course separate files are cleaner

ryanpetrello
ryanpetrello reviewed Mar 29, 2019
View reviewed changes
Copy link
Contributor

@ryanpetrello ryanpetrello left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wenottingham is there a significant enough difference between the two such that targeting with ; python_version ... won't work? It seems like a lot of extra work for us to maintain another dependency list.

@wenottingham
Copy link
Contributor Author

@ryanpetrello Every developer would need to generate both and then compare them and then know to tag things with python_version when they are different.

@AlanCoding AlanCoding mentioned this pull request Apr 11, 2019
Merged
@ryanpetrello ryanpetrello changed the title Generate separate requirements files for python2 and python3 ansible venvs [WIP] Generate separate requirements files for python2 and python3 ansible venvs Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanpetrello ryanpetrello ryanpetrello left review comments

Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenottingham @sumkincpp @ryanpetrello @awxbot