Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor testing: tox and github actions usage to simplify testing #219

Closed
8 of 11 tasks
ssbarnea opened this issue Aug 2, 2024 · 0 comments · Fixed by #246 or #250
Closed
8 of 11 tasks

Refactor testing: tox and github actions usage to simplify testing #219

ssbarnea opened this issue Aug 2, 2024 · 0 comments · Fixed by #246 or #250
Assignees
@ssbarnea
Labels
bug Something isn't working

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Aug 2, 2024 •
edited
Loading

This is an "epic" level ticket for tracking future changes to how we run tests locally on CI (GHA), so we can ensure we have a much better experience with both.

  • enable pre-commit.ci
  • configure tox lint job to run pre-commit
  • add spellchecker to pre-commit (cspell and/or codespell)
  • move linters supported by pre-commit inside pre-commit as it is much easier to maintain (and faster)
  • enable py311 and py312 GHA pipelines
  • enable one macos aarch64 job (uncovers dependency issues on arm)
  • enable ansible version matrix for testing with tox (via tox-ansible probably)
  • refactor GHA execution to make use of reusable tox workflows. Example https://github.com/ansible/ansible-lint/blob/main/.github/workflows/tox.yml#L29-L44 (lower the maintenance needed on GHA)
  • report coverage using codecov.io

Optional (less urgent)

  • enable depentabot for actions
  • enable use of constraints and depentabot updates for them

AAP-28987
@ssbarnea ssbarnea added the bug Something isn't working label Aug 2, 2024
@ssbarnea ssbarnea self-assigned this Aug 2, 2024
@ssbarnea ssbarnea pinned this issue Aug 2, 2024
This was referenced Aug 2, 2024
Merged
Merged
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
10ecfa7 
Related: #219
@ssbarnea ssbarnea mentioned this issue Aug 5, 2024
Merged
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
82cf92b 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
ba62727 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
1c023ff 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
27fa5be 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
73777f5 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
ca5e726 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
39b8526 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
abaafb5 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
2404dfc 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
7df9ae0 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
d383d04 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
4342af5 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
f9ffb75 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows
b278e6f 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Unify testing jobs into a single workflows (#223)
914f52e 
Related: #219
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Enable testing with python 3.11 and 3.12
38a4ccb 
Related: #219
@ssbarnea ssbarnea mentioned this issue Aug 5, 2024
Merged
ssbarnea added a commit that referenced this issue Aug 5, 2024
@ssbarnea
Enable testing with python 3.11 and 3.12 (#224)
838bc04 
Related: #219
This was referenced Aug 5, 2024
Merged
Merged
Merged
ssbarnea added a commit that referenced this issue Aug 13, 2024
@ssbarnea
Enable testing with an arm64 linux runner
9528c34 
Depends-On: https://github.com/coactions/dynamic-matrix/releases/tag/v3.0.1
Partial-Fix: #219
AAP-28987
ssbarnea added a commit that referenced this issue Aug 13, 2024
@ssbarnea
Enable testing with an arm64 linux runner
5a4921a 
Depends-On: https://github.com/coactions/dynamic-matrix/releases/tag/v3.0.1
Partial-Fix: #219
AAP-28987
This was referenced Aug 13, 2024
Merged
Merged
ssbarnea added a commit that referenced this issue Aug 13, 2024
@ssbarnea
Enable testing with an arm64 linux runner (#246)
5a3f586 
Depends-On: https://github.com/coactions/dynamic-matrix/releases/tag/v3.0.1
Partial-Fix: #219
AAP-28987
@ssbarnea ssbarnea unpinned this issue Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssbarnea ssbarnea

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@ssbarnea