fixes #1697 shard travis builds for python2 #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
NB: if it appears to be impossible, there is already some ticket to propose some more deep enhancement #1575 |
Closed
decentral1se
approved these changes
Jan 24, 2019
gundalow
approved these changes
Jan 24, 2019
webknjaz
suggested changes
Jan 24, 2019
|
@webknjaz Thank you for your comments, much appreciated. I replied to some, and I will adapt after you confirm the final direction to take. |
Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
themr0c
force-pushed
the
1697-shard-travis-builds-for-python2
branch
from
9664c45 to
206ce1e
Compare
Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
webknjaz
reviewed
Jan 28, 2019
|
Good news the errors on the last build https://travis-ci.com/ansible/molecule/builds/98812943 are errors that are already in master, unrelated to this PR. |
webknjaz
suggested changes
Jan 29, 2019
This reverts commit e8c5369.
…o keep the PR readable. Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
gundalow
approved these changes
Jan 30, 2019
|
👍 |
ssbarnea
pushed a commit
to ssbarnea/molecule
that referenced
this pull request
Jan 31, 2019
* fixes ansible#1697 shard travis builds for python2 Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com> * fixes ansible#1697 shard travis builds for python2 Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com> * attempt to shard tests on py27 without breaking tests on py3 Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com> * attempt to shard tests on py27 without breaking tests on py3 Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com> * attempt to shard tests on py27 without breaking tests on py3 Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com> * attempt to shard tests on py27 without breaking tests on py3 Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com> * attempt to shard tests on py27 without breaking tests on py3 Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com> * fix yaml, fix yamllint errors * Revert "fix yaml, fix yamllint errors" This reverts commit e8c5369. * Fix yaml syntax. Keep wrong indentation errors reported by yamllint to keep the PR readable. Signed-off-by: Fabrice Flore-Thebault <themr0c@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabrice Flore-Thebault themr0c@users.noreply.github.com
fixes #1697 shard travis builds for python2
PR Type