Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed custom logger #2978

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Removed custom logger #2978

merged 1 commit into from
Nov 18, 2020

Conversation

ssbarnea
Copy link
Member

Molecule no longer uses a custom logger class and we make use of the standard python logger class.

This change replaces logger.success() and logger.out() with logger.info() calls.

Copy link
Contributor

@tadeboro tadeboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found no major issues in the code. I do have two minor questions, but that is it. Once we resolve them, things are good as far as I am concerned.

On an unrelated note: I also noticed that the BakedCommand is a data class during the review. Which all fine and dandy, but those are only available in python >= 3.7, and Molecule advertises compatibility with 3.6. Not sure why tests did not catch this. Unfortunately, I have no time to investigate right now,

src/molecule/test/unit/test_config.py Outdated Show resolved Hide resolved
src/molecule/verifier/testinfra.py Show resolved Hide resolved
Molecule no longer uses a custom logger class and we make use of the
standard python logger class.

This change replaces logger.success() and logger.out() with
logger.info() calls.
@ssbarnea
Copy link
Member Author

@tadeboro There is a bug that we missed to add dataclasses for py36 but our testing failed to spot it because another dependency did install it. I will add a patch just to be sure.

@ssbarnea ssbarnea merged commit 932257d into master Nov 18, 2020
@ssbarnea ssbarnea deleted the devel branch November 18, 2020 16:49
abtreece added a commit to ansible-community/molecule-inspec that referenced this pull request Nov 20, 2020
The custom logger class has been removed from Molecule and thus we must
remove those references from the plugin.

ansible/molecule#2978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated marks deprecations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants