More packaging fixes #3314
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,37 @@ | ||
| prune .github | ||
| prune asset | ||
| prune playbooks | ||
| prune snap | ||
| prune zuul.d | ||
|
There was a problem hiding this comment. Why do you want to exclude it from the sdist? There was a problem hiding this comment. I do not see any use to include CI config in sdist, same with .github folder. On the other hand I kept test related files so you can still run tests from source archive. There was a problem hiding this comment. The whole point of the sdist is to provide the sources for stuff, as much as possible. It's right there in the name. The users needing a small thing will use the wheel anyway (and it's configured separately). Many things use sdists as the source of truth, in particular — the downstream packagers. So don't exclude things without a really compelling reason. |
||
| prune docs/docstree | ||
| include .config/molecule/config.yml | ||
| include .ansible.cfg | ||
| include .coveragerc | ||
| include .git_archival.txt | ||
| include .pre-commit-config.yaml | ||
| include .pylintrc | ||
| include .pyup.yml | ||
| include .readthedocs.yml | ||
| include .yamllint | ||
| include DCO_1_1.md | ||
| include bindep.txt | ||
| include conftest.py | ||
| include constraints.txt | ||
| include mypy.ini | ||
| include tox.ini | ||
| include docs/_static/images/*.* | ||
| include docs/*.* | ||
| recursive-include src .ansible-lint | ||
| recursive-include src *.flake8 | ||
| recursive-include src *.j2 | ||
| recursive-include src *.md | ||
| recursive-include src *.py | ||
| recursive-include src *.rst | ||
| recursive-include src *.typed | ||
| recursive-include src *.yaml | ||
| recursive-include src *.yamllint | ||
| recursive-include src *.yml | ||
| recursive-include src cookiecutter.json | ||
| recursive-include src/molecule/test/scenarios extra-host | ||
| recursive-include src/molecule/test/scenarios hosts | ||
| recursive-include tools *.sh | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this line is the only entry that actually makes sense to be in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is far from true, i tried this myself but the result caused problems in multiple places, one of them was the check-manifest. The other was that extra built docs were included and that desired json/yaml were not included from inside src/molecule. On the other hand if you put generic recursive includes for those two extensions you may endup getting stuff like
src/molecule/test/.mypy_cache/.../foo.jsonwhich are excluded by default.I know that testing behavior of Manifest.in is quite tricky as it is highly dependent on what you may have on disk, like temp files, stuff that are not VCS tracked.
check-manifestcommand is very useful for debugging as it reports both kind of unexpected exclusions or inclusions but still fails to give correct recommendations or to spot the bug I mentioned.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, so your problem was because of the recursive inclusion and not a bug in
setuptools-scm. That makes sense, then.