-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore scenarios in virtual envrionments #3996
Conversation
2fa8d24
to
7a37dd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test(s) for it.
yeah, tests would be good here. The only way I can think of testing this would be to touch a molecule.yml file in a scenario tree in a gitignored directory and ensure it isn't found. If you move the filtering logic into it's own function, it might be easier to monkeypatch it in a test so you can turn it on and off to do both a psitive and negative test. |
6ff9e1f
to
472b290
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after our conversation today, I think both + and - test can be added w/o the overhead of a venv. LMK if you need anything along the way.
194fc51
to
3dfe232
Compare
3dfe232
to
11c8dd5
Compare
Ignore scenarios in virtual environments.
This only works when repository is initialized with git otherwise just returns all scenario files.
Fixes: #3992