Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore scenarios in virtual envrionments #3996

Merged
merged 5 commits into from
Aug 13, 2023
Merged

Conversation

audgirka
Copy link
Contributor

@audgirka audgirka commented Aug 10, 2023

Ignore scenarios in virtual environments.
This only works when repository is initialized with git otherwise just returns all scenario files.

Fixes: #3992

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test(s) for it.

@cidrblock
Copy link
Contributor

yeah, tests would be good here. The only way I can think of testing this would be to touch a molecule.yml file in a scenario tree in a gitignored directory and ensure it isn't found.

If you move the filtering logic into it's own function, it might be easier to monkeypatch it in a test so you can turn it on and off to do both a psitive and negative test.

@audgirka audgirka force-pushed the fix/ignore_venv_secnarios branch 4 times, most recently from 6ff9e1f to 472b290 Compare August 10, 2023 15:48
@cidrblock cidrblock self-requested a review August 11, 2023 03:37
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after our conversation today, I think both + and - test can be added w/o the overhead of a venv. LMK if you need anything along the way.

@audgirka audgirka merged commit facee7d into main Aug 13, 2023
11 checks passed
@audgirka audgirka deleted the fix/ignore_venv_secnarios branch August 13, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

molecule list finds scenarios in virtual envrionments
3 participants