dynamically get the nodeport host #4158
Merged
+21
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahoon
force-pushed
the
get-nodeport-host-dynamically
branch
from
c2e8421
to
ac79fa3
Compare
|
Hello, I believe this would help streamline the experience for users trying to use ephemeral kubevirt VMs. Can someone provide feedback? Thx! |
Qalthos
force-pushed
the
get-nodeport-host-dynamically
branch
from
ac79fa3
to
22288ef
Compare
|
Qalthos
approved these changes
Sep 9, 2024
cidrblock
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
This is an update to the example doc of
Using Kubevirt. The purpose is to dynamically get the NodePort host to replace the hardcoded hostname that is used for the VM SSH connection.The problem we solved
By fetching the
hostnamedynamically, we avoid using a pre-defined host for the VM SSH connection, that will reduce the the potential failures by the connection problem with the host. In this update, the hostname for the SSH connection is fetched dynamically, which is the K8S node where the VM is running.I get this tested in our environment with @jangel97
Thanks.