Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Migrate PEP 517 backend to tomllib+tomli #501

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented May 10, 2023

tomllib is a part of stdlib since Python 3.11 and tomli is used as a fallback for the older Python versions. The latter is API-compatible with the former.

Fixes #504.

SUMMARY

$sbj.

ISSUE TYPE
  • Maintenance Pull Request
  • Packaging Pull Request
ADDITIONAL INFORMATION

N/A

@webknjaz webknjaz self-assigned this May 10, 2023
@webknjaz webknjaz force-pushed the maintenance/pep517-tomllib branch 5 times, most recently from 64515a3 to b349c98 Compare May 11, 2023 01:29
@Qalthos Qalthos force-pushed the maintenance/pep517-tomllib branch from b349c98 to 46f244e Compare November 10, 2023 18:32
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/ansible-pylibssh-501
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@Qalthos Qalthos force-pushed the maintenance/pep517-tomllib branch from 46f244e to f645dcb Compare November 14, 2023 18:36
@webknjaz webknjaz force-pushed the maintenance/pep517-tomllib branch 2 times, most recently from d8cb8a9 to 066aaff Compare November 28, 2023 23:51
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 28, 2023
@webknjaz webknjaz linked an issue Nov 28, 2023 that may be closed by this pull request
`tomllib` is a part of stdlib since Python 3.11 and `tomli` is used as
a fallback for the older Python versions. The latter is API-compatible
with the former.
@webknjaz webknjaz force-pushed the maintenance/pep517-tomllib branch from 066aaff to 0671f03 Compare November 29, 2023 01:01
@webknjaz webknjaz merged commit 822c1a5 into ansible:devel Nov 29, 2023
7 of 16 checks passed
webknjaz added a commit that referenced this pull request Jan 3, 2024
The build backend originally switched to it in
#501 but this was forgotten.
@webknjaz
Copy link
Member Author

There were two leftover toml references in some packaging-related files, #534 will get rid of them too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please drop toml dependency
1 participant