Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think this should fix packit? #507

Merged
merged 4 commits into from
Jun 16, 2023
Merged

I think this should fix packit? #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af55a05
I think this should fix packit?
Qalthos Jun 15, 2023
8e05c5c
Fix Fedora 38+?
Qalthos Jun 15, 2023
bd328fa
Drop -vv from tox as that conflicts with the implicit(!) -q
Qalthos Jun 15, 2023
98fd584
Drop installpkg
Qalthos Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .packit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,22 @@ downstream_package_name: python3-ansible-pylibssh

jobs:
- job: copr_build
enable_net: true
targets:
# - epel-9
# - fedora-all
- fedora-development
- fedora-stable
trigger: pull_request
- job: tests
enable_net: true
targets:
# - epel-9
- fedora-development
- fedora-stable
trigger: pull_request
- job: propose_downstream
enable_net: true
dist_git_branches: fedora-all
trigger: release

Expand Down
1 change: 1 addition & 0 deletions docs/changelog-fragments/507.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Restore online access to packit builds -- by :user:`Qalthos`
4 changes: 1 addition & 3 deletions packaging/rpm/ansible-pylibssh.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ PYTHONPATH="$(pwd)/bin" \

# Fedora:
%if 0%{?fedora}
%pyproject_wheel %{python_importable_name}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the effect of this?

%pyproject_wheel
%endif

# RHEL or CentOS:
Expand Down Expand Up @@ -223,8 +223,6 @@ export PYTHONPATH="%{buildroot_site_packages}:${PYTHONPATH}"
# Fedora:
%if "%{?fedora:SET}" == "SET"
%tox -e just-pytest -- \
-vv \
--installpkg '%{_builddir}/%{pypi_name}-%{upstream_version}/pyproject-wheeldir/%{whl_glob}' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Qalthos why? This would cause a separate wheel build which means that the tests would run against something else..

-- \
--deselect tests/unit/scp_test.py::test_get \
--deselect tests/unit/scp_test.py::test_put
Expand Down