Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪🐛 Make coverage use upstream Cython plugin #538

Merged
merged 1 commit into from
Nov 28, 2023
Merged

🧪🐛 Make coverage use upstream Cython plugin #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ exclude_lines =
branch = true
cover_pylib = false
parallel = true
# FIXME: https://github.com/cython/cython/issues/3636
# plugins = Cython.Coverage
plugins = cython_coverage
plugins = Cython.Coverage
relative_files = true
source =
tests
Expand Down
62 changes: 0 additions & 62 deletions bin/cython_coverage.py
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions docs/changelog-fragments/538.contrib.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Switched back to using Cython's native plugin for measuring
code coverage -- by :user:`webknjaz`
9 changes: 3 additions & 6 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,14 @@ setenv =
COV_CORE_CONFIG = {toxinidir}/.coveragerc
COV_CORE_DATAFILE = {toxinidir}/.coverage
COV_CORE_SOURCE =
PYTHONPATH = {toxinidir}/bin{:}{env:PYTHONPATH:}
SEGFAULT_SIGNALS = all
commands =
-sh -c "CFLAGS=-DCYTHON_TRACE_NOGIL=1 \
{envpython} -m Cython.Build.Cythonize \
--force \
--inplace \
-sh -c "\
{envpython} -Im cython \
--directive=embedsignature=True \
--directive=emit_code_comments=True \
--directive=linetrace=True \
--directive=profile=True \
-3 \
{toxinidir}/src/pylibsshext/*.pyx"
{env:CATCHSEGV_BINARY:} {envpython} -m \
pytest \
Expand Down
Loading