-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CLI / Config with Cobra / Viper #1043
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## devel #1043 +/- ##
==========================================
+ Coverage 42.47% 43.04% +0.56%
==========================================
Files 43 47 +4
Lines 6775 7430 +655
==========================================
+ Hits 2878 3198 +320
- Misses 3666 3994 +328
- Partials 231 238 +7
... and 6 files with indirect coverage changes
|
63d909b
to
6ad3ef8
Compare
Overall looking good, Can I get some example of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a description to this PR or create an associated issue with more information. For a PR this big / important, we should summarize what we're doing here and the approach we're taking. Here's a couple examples for you to follow:
Trace seems to be strange even on the original and dosent do what I expected at all. Feel free to ignore this trace comment and this PR looks OK to me 😄 |
732af8a
to
72139fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
Can we resolve the conflicts then we are good to merge 😄
4930d3f
to
642d56a
Compare
Quality Gate passedIssues Measures |
The Problem
Currently Receptor uses a custom config parser that is tightly coupled as the parser not only reads the config file, but also initializes the relevant parts of the project. This custom parser is also not idiomatic, making it more difficult to understand the project.
The custom parser is difficult to extend, this can be seen in the reluctance to add more config fields, instead relying on environment variables.
The solution
This change proposes a backwards compatible way to move away from relying on the old cli and using cobra/viper to implement a version 2.