Retry logic for stdin and stdout from pod #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterseth
force-pushed
the
k8s_retry_stdin_to_pod
branch
from
8891cae to
9718fa4
Compare
shanemcd
reviewed
Oct 3, 2022
shanemcd
reviewed
Oct 3, 2022
fosterseth
force-pushed
the
k8s_retry_stdin_to_pod
branch
from
9718fa4 to
147953a
Compare
Currently receptor has one attempt at opening stdin and stdout streams from the pod. An error during this prevents any chance of the pod running successfully. This change provides some retry logic when opening these streams to offer better stability when receptor interacts with a k8s cluster.
fosterseth
force-pushed
the
k8s_retry_stdin_to_pod
branch
from
147953a to
3c982b1
Compare
Closed
9 tasks
shanemcd
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently receptor has one attempt at opening stdin and stdout streams from the pod.
An error during this prevents any chance of the pod running successfully.
This change provides some retry logic when opening these streams to offer better stability when receptor interacts with a k8s cluster.
see ansible/awx#12881