Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

Add documentation structure #18

Merged
merged 1 commit into from
Aug 9, 2017
Merged

Add documentation structure #18

merged 1 commit into from
Aug 9, 2017

Conversation

crisidev
Copy link
Collaborator

@crisidev crisidev commented Aug 8, 2017

This implements the documentation structure of #16

Once this is merged, we can push the docs to readthedocs and improve the API documentation through sphinx.

@crisidev crisidev mentioned this pull request Aug 8, 2017
@crisidev
Copy link
Collaborator Author

crisidev commented Aug 8, 2017

Hum, tox for py27 is failing in teardown and setup of test cases like:

____ ERROR at setup of test_accounting_reply_unpack[!-follow-FOLLOW] _____
self = {'LANG': 'en_US.UTF-8', 'COV_CORE_SOURCE': 'tacacs_plus', 'COV_CORE_CONFIG': '', 'PYTHONHASHSEED': '3908957131', 'VIRT...usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin', 'COV_CORE_DATAFILE': '/home/travis/build/crisidev/tacacs_plus/.coverage'}
key = 'PYTEST_CURRENT_TEST'
item = 'tests/test_tacacs_plus.py::test_accounting_reply_unpack[\x00\x00\x00\x00!\x00\x00-follow-FOLLOW] (setup)'
    def __setitem__(self, key, item):
>       putenv(key, item)
E       TypeError: must be string without null bytes, not str
.tox/py27/lib/python2.7/os.py:473: TypeError
___ ERROR at teardown of test_accounting_reply_unpack[!-follow-FOLLOW] ___
self = {'LANG': 'en_US.UTF-8', 'COV_CORE_SOURCE': 'tacacs_plus', 'COV_CORE_CONFIG': '', 'PYTHONHASHSEED': '3908957131', 'VIRT...usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin', 'COV_CORE_DATAFILE': '/home/travis/build/crisidev/tacacs_plus/.coverage'}
key = 'PYTEST_CURRENT_TEST'
item = 'tests/test_tacacs_plus.py::test_accounting_reply_unpack[\x00\x00\x00\x00!\x00\x00-follow-FOLLOW] (teardown)'
    def __setitem__(self, key, item):
>       putenv(key, item)
E       TypeError: must be string without null bytes, not str

I honestly do not understand why...

@crisidev
Copy link
Collaborator Author

crisidev commented Aug 8, 2017

Ah, looks like to be related to pytest: pytest-dev/pytest#2644

@ryanpetrello
Copy link
Contributor

@crisidev thanks for spotting that, if you want to rebase, I've fixed the tests via a2c86f5

@ryanpetrello ryanpetrello merged commit 0606df8 into ansible:master Aug 9, 2017
@crisidev
Copy link
Collaborator Author

crisidev commented Aug 9, 2017

Yep! Will rebase and update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants