Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only start download, if there is a different version then installed #103

Merged

Conversation

peshay
Copy link
Contributor

@peshay peshay commented Nov 16, 2018

I added to the main tasks: when: oracle_java_version_installed != oracle_java_version_string
So the download/installation would only start if the installed version does not matches the intended version.
I also had some Warnings in Ansible, so I fixed them all.

May I also suggest to add a task that find the lastest Update version of a JDK release? So this could then automatically fill in things like oracle_java_rpm_filename, oracle_java_rpm_url, oracle_java_version_string depending on which oracle_java_version is set.

@steenzout steenzout changed the base branch from master to develop November 24, 2018 07:43
@steenzout steenzout self-requested a review November 24, 2018 07:44
@steenzout steenzout merged commit cca9a25 into ansiblebit:develop Nov 24, 2018
@steenzout steenzout added this to the 6.22.8 milestone Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants