feat: adding step for importing library #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
the
enhancement
RobPasMue
requested changes
Oct 16, 2023
RobPasMue
changed the title
RobPasMue
reviewed
Oct 26, 2023
| run: | | ||
| library_name=${{ inputs.library-name }} | ||
|
|
||
| library_name="${library_name//-/.}" |
There was a problem hiding this comment.
I'm not sure if this will always work. 90% of the cases it will... but I'm guessing some will fail
There was a problem hiding this comment.
I kind of agree.. but I cannot come up with something better 🤷🏻♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an explicit step for testing the import of the library.
Close #347
Improve #276