Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make optional use latest index in landing page #493

Merged
merged 4 commits into from
May 24, 2024

Conversation

vgelbgras
Copy link
Contributor

In this PR, I added an input to doc-deploy-dev and doc-deploy-stable so we can skip when needed the step to overwrite the index.html page.

It will be used in some internal projects.

Tested here successfully.

** Correct the name of the branch used in PR#492

feat: make optional use latest index in landing page

Update action.yml

Update action.yml

Update action.yml

feat: make optional use latest index in landing page
@vgelbgras vgelbgras self-assigned this May 24, 2024
@vgelbgras vgelbgras requested a review from a team as a code owner May 24, 2024 08:24
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement General improvements to existing features label May 24, 2024
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this. Please, apply the suggestions to ensure that the multi-line description render as expected.

Once merged, I will perform a patch release.

doc-deploy-dev/action.yml Outdated Show resolved Hide resolved
doc-deploy-stable/action.yml Outdated Show resolved Hide resolved
vgelbgras and others added 2 commits May 24, 2024 11:13
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
@vgelbgras
Copy link
Contributor Author

Approving this. Please, apply the suggestions to ensure that the multi-line description render as expected.

Once merged, I will perform a patch release.

@jorgepiloto could you add me in the contributors? It looks like I am not authorized to merge the PR.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging

@RobPasMue RobPasMue merged commit ca1b8d7 into main May 24, 2024
16 checks passed
@RobPasMue RobPasMue deleted the feat/make-optional-to-copy-landing-page branch May 24, 2024 09:54
@RobPasMue
Copy link
Member

Let's wait for #491 to be merged before doing the patch release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants