Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update doc deploy actions to to correct local search path on landing page #494

Merged
merged 1 commit into from
May 28, 2024

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented May 28, 2024

This PR addresses a search issue in the deployment script by updating the search action path in the landing page. Previously, the search action was set to search.html, causing search functionality to look for the incorrect file. With this fix, the search action path is updated to version/stable/search.html for stable versions or version/dev/search.html for development versions. This ensures that the search functionality points to the correct location, resolving the search issue effectively.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label May 28, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I did realize about this behavior but never ended up reporting it. Thanks a lot @Revathyvenugopal162!

@Revathyvenugopal162
Copy link
Contributor Author

Tested successfully in https://templates.ansys.com/

@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review May 28, 2024 08:27
@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner May 28, 2024 08:27
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Revathyvenugopal162 Revathyvenugopal162 merged commit 488ef69 into main May 28, 2024
16 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/search-with-redirection branch May 28, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects or glitches reported by users or developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants