Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an optional input for checkout so it can be skipped, if needed #504

Merged
merged 9 commits into from
Jun 12, 2024

Conversation

myoung301
Copy link
Contributor

The checkout remains the default, but can be skipped if set to false. This can be useful when there are prior steps to build elements that should be packed into the wheelhouse. For example, some projects have a step to build cython .pyd files and those .pyd files should go into the wheel file. The checkout step would purge the repo and clear the files from the previous build step. Now, projects that have this requirement can opt to skip the checkout.

It can be useful to skip the checkout if there is a prior step that does some setup. For example, a project might have a cython step that compiles some modules which should be packaged into the wheelhouse. This can be done in a prior step and then this action triggered with the checkout disabled.
@myoung301 myoung301 requested a review from a team as a code owner June 11, 2024 17:32
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@myoung301
Copy link
Contributor Author

@ansys-reviewer-bot review

@ansys-reviewer-bot
Copy link
Contributor

Okay, I will trigger a review of your PR.

@myoung301 myoung301 changed the title Add an optional input for checkout so it can be skipped, if needed feat: add an optional input for checkout so it can be skipped, if needed Jun 11, 2024
@myoung301 myoung301 marked this pull request as draft June 11, 2024 18:18
@myoung301
Copy link
Contributor Author

Fixed the syntax of the condition and verified it works with true, false, and without the parameter (defaults to true).

@myoung301 myoung301 marked this pull request as ready for review June 11, 2024 20:28
@RobPasMue
Copy link
Member

LGTM! Merging. We will do a patch release with this change.

@RobPasMue RobPasMue merged commit c78f633 into ansys:main Jun 12, 2024
10 of 11 checks passed
@RobPasMue
Copy link
Member

Release on the way - v6 will have your change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants