Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adding a warning for vulnerability_checks with private repositories #506

Merged
merged 2 commits into from
Jun 13, 2024
Merged

docs: adding a warning for vulnerability_checks with private repositories #506

merged 2 commits into from
Jun 13, 2024

Conversation

clatapie
Copy link
Contributor

No description provided.

@clatapie clatapie requested a review from a team as a code owner June 12, 2024 16:02
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@clatapie clatapie changed the title doc: adding a warning for vulnerability_checks with private repositories docs: adding a warning for vulnerability_checks with private repositories Jun 12, 2024
@clatapie clatapie mentioned this pull request Jun 12, 2024
Merged
SMoraisAnsys
SMoraisAnsys previously approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I left a minor comment on jinja vulnerability to add visibility on the range of affected versions.

check-vulnerabilities/ignored-safety.txt Outdated Show resolved Hide resolved
RobPasMue
RobPasMue requested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is, it is not going to work. Also, the purpose of this PR is not adding the comments - it is for adding the warning. Please do it in a separate PR

check-vulnerabilities/ignored-safety.txt Outdated Show resolved Hide resolved
@SMoraisAnsys SMoraisAnsys dismissed their stale review June 13, 2024 07:18

Didn't see the PR title which makes my review not accurate...

@clatapie
Copy link
Contributor Author

Thank you very much for all your feedback.
I will revert my changes within the check-vulnerabilities/ignored-safety.txt file and open an issue about it as suggested by @RobPasMue.

@RobPasMue RobPasMue enabled auto-merge (squash) June 13, 2024 15:32
@RobPasMue RobPasMue merged commit ac9f45e into main Jun 13, 2024
16 checks passed
@RobPasMue RobPasMue deleted the doc/vulnerability_checks branch June 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clatapie @RobPasMue @SMoraisAnsys