Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: doc-changelog conventional commits #515

Merged
merged 53 commits into from
Aug 1, 2024
Merged

Conversation

klmcadams
Copy link
Contributor

@klmcadams klmcadams commented Jul 8, 2024

By default, the doc-changelog action will check if there is a conventional commit type in the PR title (both lowercase and uppercase types are allowed). The conventional commit type is also removed from the titles that are placed in the towncrier fragment file. For example, if you have your PR title "fix: doc-changelog issue", then the towncrier fragment file's contents will only be "doc-changelog issue"

If you want to use labels to create the changelog fragment, you have to add the use-labels: true line to the doc-changelog job.

This will break repositories until the pyproject.toml files are updated to include the additional sections listed in the doc-changelog documentation

Conventional commit tests:

Fails when there is no conventional commit type in the title
Passes when there is an all caps conventional commit type in the title
Passes when there is an all lowercase conventional commit type in the title

Labels tests:

Documentation label
Test label

@klmcadams klmcadams requested a review from a team as a code owner July 8, 2024 14:44
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

doc-changelog/action.yml Outdated Show resolved Hide resolved
doc-changelog/action.yml Show resolved Hide resolved
doc/source/doc-actions/examples/doc-changelog-basic.yml Outdated Show resolved Hide resolved
doc-changelog/parse_pr_title.py Show resolved Hide resolved
doc-changelog/parse_pr_title.py Show resolved Hide resolved
doc-changelog/parse_pr_title.py Show resolved Hide resolved
@klmcadams klmcadams requested a review from RobPasMue July 11, 2024 19:20
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SMoraisAnsys SMoraisAnsys dismissed their stale review August 1, 2024 13:09

Changes performed

…mit type (#529)

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@klmcadams klmcadams enabled auto-merge (squash) August 1, 2024 13:52
@klmcadams klmcadams merged commit af547f1 into main Aug 1, 2024
13 checks passed
@klmcadams klmcadams deleted the feat/doc-changelog-cc branch August 1, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants