-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use one input to specify the tag the branch was created from in doc-deploy-changelog #547
Conversation
klmcadams
commented
Aug 23, 2024
- Consolidate "update-release-branch" and "update-main-branch" into one input: "release-from-main"
- By default, "release-from-main" is false, meaning the action assumes the tag was created on a release branch
- Included a detailed description for "release-from-main" to clarify the different options
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this really helps in understanding what the action is doing! A couple of minor comments, but I'm completely happy if you say that it's wordy enough already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something else came to me while I was re-reading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @klmcadams for the change!
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>