Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use one input to specify the tag the branch was created from in doc-deploy-changelog #547

Merged
merged 8 commits into from
Aug 26, 2024

Conversation

klmcadams
Copy link
Contributor

  • Consolidate "update-release-branch" and "update-main-branch" into one input: "release-from-main"
  • By default, "release-from-main" is false, meaning the action assumes the tag was created on a release branch
  • Included a detailed description for "release-from-main" to clarify the different options

@klmcadams klmcadams requested a review from a team as a code owner August 23, 2024 19:37
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Aug 23, 2024
Copy link

@Andy-Grigg Andy-Grigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this really helps in understanding what the action is doing! A couple of minor comments, but I'm completely happy if you say that it's wordy enough already.

doc-deploy-changelog/action.yml Outdated Show resolved Hide resolved
Copy link

@Andy-Grigg Andy-Grigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something else came to me while I was re-reading

doc-deploy-changelog/action.yml Outdated Show resolved Hide resolved
doc-deploy-changelog/action.yml Outdated Show resolved Hide resolved
doc-deploy-changelog/action.yml Outdated Show resolved Hide resolved
Copy link

@Andy-Grigg Andy-Grigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Copy link

@da1910 da1910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @klmcadams for the change!

Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@klmcadams klmcadams merged commit 241f9e9 into main Aug 26, 2024
16 checks passed
@klmcadams klmcadams deleted the fix/one-branch-input branch August 26, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects or glitches reported by users or developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants