refactor: replacing-check-with-scan #666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
the
fix
germa89
commented
Jan 7, 2025
Comment on lines
+3
to
+8
| scanning-settings: | ||
| max-depth: 6 | ||
| exclude: | ||
| - "node_modules" | ||
| - "lib/other/**" | ||
| - "**/*.js" |
There was a problem hiding this comment.
Also, not sure if should add something else here. I thought about the venv folders, but presumable, those are covered below under the python section?
Anyway, if anyone have suggestions, I'm happy to heard them. :)
RobPasMue
requested changes
Jan 7, 2025
Interesting... Yeah. I'm happy to help! Ping me tomorrow when available :) |
|
btw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title, using
scaninstead of check.Close #641
Notes
I have keep the
--output screenbecause... I guess otherwise it is not printed? Anyways, I'm not 100% sure on this. Feel free to remove it and keep the output to json only.The
||added to avoid failing on error.