Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with "Edit" links #141

Closed
RobPasMue opened this issue Oct 26, 2022 · 6 comments
Closed

Problems with "Edit" links #141

RobPasMue opened this issue Oct 26, 2022 · 6 comments
Assignees

Comments

@RobPasMue
Copy link
Member

Looks like the edit link color theme is "white" in light mode, which makes it invisible to bare eye. In dark mode it is working properly though. Could we look into it?

See https://dev.geometry.docs.pyansys.com/

Light mode:
image
image

Dark mode:
image

@germa89
Copy link
Contributor

germa89 commented Oct 31, 2022

hahahaha.. I just came to post the same issue! xD

@germa89
Copy link
Contributor

germa89 commented Oct 31, 2022

I would also add that the Edit links return 404 when you use it on Gallery examples or autogenerated functions/classes.

@RobPasMue
Copy link
Member Author

Examples should work @germa89. Check on PyGeometry just in case.

@MaxJPRey
Copy link
Contributor

MaxJPRey commented Nov 2, 2022

I noticed the same issue as @germa89 .

@Revathyvenugopal162
Copy link
Contributor

Revathyvenugopal162 commented Nov 2, 2022

If we are generating examples with sphinx gallery, it will give an error page, since the example pages are generated from a python module by sphinx gallery. But in pygeometry it is different, we are not generating examples notebook with sphinx gallery, instead we are directly proving the notebook, so it will direct the edit link to the examples in pygeometry. That can be a reason that examples are working in pygeometry and not in other libs.

@RobPasMue
Copy link
Member Author

RobPasMue commented Nov 11, 2022

Has this already been solved with #143 @Revathyvenugopal162? If that's not the case, please reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants