Maintain edit this button style and version switcher #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
jorgepiloto
requested changes
Nov 4, 2022
| This is unexpected. The page you are requesting does not exist. | ||
|
|
||
| If this page should exist, please contact `{{ theme_contact_mail }} <mailto:{{ theme_contact_mail }}`_. | ||
| If this page should exist, please contact `{{ theme_contact_mail }} <{{ theme_contact_mail }}>`_. |
There was a problem hiding this comment.
Is there any reason behind removing the mailto directive and the :orphan: one, @Revathyvenugopal162?
There was a problem hiding this comment.
Yes,
- The 404-page html is not rendered as expected. you can check it https://sphinxdocs.ansys.com/404.html. i am expecting, the toc tree, logo and nav bar on the page, so i will open another PR for customized 404 page in which can redirect for edit this page for API/ examples.
- We are not putting the 404.rst page in our doc, rather we are importing from ansys-sphinx-theme, later rendered to an html, so if we are giving/not giving orphan, doesnt matter, since we are giving the directive orphan to silence the spurious
document isn't included in any toctreewarning. and it is directly rendering as 404 html, not 404.rst
There was a problem hiding this comment.
Thanks a lot for the detailed explanation on the 404 page, @Revathyvenugopal162.
What about the mailto directive? Did it introduce any issues?
There was a problem hiding this comment.
it is also not rendering as expected, not giving the href for the link.
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
jorgepiloto
approved these changes
Nov 7, 2022
|
Merging since all reviewers gave green-light |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix partially #141.