Quick fix for the left panel size #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
MaxJPRey
reviewed
Oct 5, 2022
Comment on lines
+534
to
+535
| flex: 0 0 20%; | ||
| max-width: 20%; |
There was a problem hiding this comment.
Let's keep an eye on it because in the past having the "size" of a panel based on percentage was the cause of some issues.
There was a problem hiding this comment.
Yeah... PyGeometry suffered of this issue with the percentage... Let's see
There was a problem hiding this comment.
This time i am expecting , if the line is longer than the expected, it should go to the second line.
This was referenced Oct 5, 2022
RobPasMue
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The left panel is not rendering correctly, opened issue in dev guide(ansys/pyansys-dev-guide#191), try to fix by rendering the left panel content by the next line, if line is long.
Fix #131.