Fix version switcher styling #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jorgepiloto
reviewed
Nov 16, 2022
| background-color: var(--pst-color-background); | ||
| border-color: var(--pst-color-border); | ||
| color: var(--pst-color-text-base) | ||
| background-color: #D09735!important; |
There was a problem hiding this comment.
Do we really want to use this color, see https://www.color-hex.com/color/d09735.
I am not sure if this is in conflict with our style guidelines. I think it works fine for the dark theme, but for the light one it may not be the best.
There was a problem hiding this comment.
No, it is not conflicting IMO, since the navigation bar is always black (in dark and in light) and it is only at the time of hovering, if you are putting the dropdown. But i am open to change.
Revathyvenugopal162
added a commit
that referenced
this pull request
Nov 28, 2022
* Fix broken version switch styling * Add style with specific color on active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken version switch styling.