Migrate to pyansys/actions and include get_version_match function #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
jorgepiloto
requested changes
Nov 24, 2022
There was a problem hiding this comment.
Thanks for implementing this, @Revathyvenugopal162. I see that you took advantage of the pyansys/actions, nice!
Just left some suggestions about the way we manipulate the CNAME to make sure that it is only defined in one place.
Apart from those, everything looks great!
jorgepiloto
reviewed
Nov 24, 2022
jorgepiloto
requested changes
Nov 24, 2022
|
@Revathyvenugopal162 remember that if you change "Required" stages of your workflow, you have to change them in the settings of the repository. Otherwise the checks won't be green. This basically applies to the FYI: I already did it for you this time |
jorgepiloto
changed the title
jorgepiloto
force-pushed
the
feat/add-default-position-switcher
branch
2 times, most recently
from
5bf5ddc
to
fb18986
Compare
Revathyvenugopal162
added a commit
that referenced
this pull request
Nov 28, 2022
…ion (#153) * Add default position for version switcher * use pyansys actions * change the workflow name * change the workflow names * Add version in conf * Change lib name * Add queue for build * add version match fn in theme * Add context * give default version to the switcher * Update init file * delete version html file * CI: update workflows Co-authored-by: Jorge Martinez Garrido <jorge.martinezgarrido@ansys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix as per discussion ansys/pyansys-dev-guide#211 (comment), default position for the version switcher as per the image.