Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: inherit from pydata-sphinx-theme==0.12.0 #155

Merged
merged 7 commits into from
Jan 24, 2023
Merged

MAINT: inherit from pydata-sphinx-theme==0.12.0 #155

merged 7 commits into from
Jan 24, 2023

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Nov 24, 2022 •
edited
Loading

Fix #183

@github-actions github-actions bot added maintenance Generic maintenance related enhancement General improvements to existing features labels Nov 24, 2022
@jorgepiloto jorgepiloto changed the title Add pydata-sphinx-theme FAET: update to latest pydata-sphinx-theme Nov 24, 2022
@Revathyvenugopal162 Revathyvenugopal162 changed the title FAET: update to latest pydata-sphinx-theme FEAT: update the layout of ansys-sphinx-theme Nov 24, 2022
@jorgepiloto jorgepiloto mentioned this pull request Nov 24, 2022
Closed
@jorgepiloto
Copy link
Member

There seems to be an issue with the JSON builder. I'm running some debugging commits just in case.

@jorgepiloto
Copy link
Member

I just restored the "pydata-sphinx-version" to check if this is caused by the new versions. I am not getting the error locally.

@jorgepiloto
Copy link
Member

This is caused by the version. We need to identify for which version does the JSON builder break. If we do not find a workaround for this, either we add an option in pyansys/actions to specify desired builders or we restore our local doc-build job to only render HTML and PDF.

@jorgepiloto
Copy link
Member

However, I am afraid that this spreads to our projects and they can no longer build JSON.

@jorgepiloto
Copy link
Member

Documentation fails for py310 + pydata-sphinx-theme==0.10.1. Let's try with py39.

@jorgepiloto jorgepiloto force-pushed the feat/update-pydata branch 2 times, most recently from 343f49a to 4abded5 Compare November 25, 2022 08:53
@jorgepiloto
Copy link
Member

I bet the issue is with the JSON. From the CI log, you can see that the PDF has errors but those are ignored (due to the logic we apply in our Makefile) and that the JSON builder starts but then fails.

@jorgepiloto
Copy link
Member

Alright, I am able to reproduce this issue locally. It is the JSON builder.

@jorgepiloto
Copy link
Member

This issue needs to be fixed in Sphinx, I am opening a pull-request there and linking to this one.

@jorgepiloto jorgepiloto mentioned this pull request Nov 25, 2022
Closed
@Revathyvenugopal162
Copy link
Contributor Author

This issue needs to be fixed in Sphinx, I am opening a pull-request there and linking to this one

The issue is with the function in functools used by pydata-sphinx-theme.

sphinx-doc/sphinx#10990 (comment) we are able to find the issue, and let's wait until pydata fix this.

This was referenced Jan 4, 2023
Closed
Merged
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review January 23, 2023 15:41
@RobPasMue
Copy link
Member

So... are we just tackling in this PR the update to pydata-sphinx-theme 0.12.0 or are we also fixing our CSS-related issues?

@Revathyvenugopal162
Copy link
Contributor Author

No there are lots of styles to change, we are just updating to to pydata-sphinx-theme 0.12.

RobPasMue
RobPasMue approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, LGTM!

MaxJPRey
MaxJPRey approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jorgepiloto jorgepiloto changed the title FEAT: update the layout of ansys-sphinx-theme MAINT: inherit from pydata-sphinx-theme==0.12.0 Jan 24, 2023
@jorgepiloto jorgepiloto merged commit 0cd50fc into main Jan 24, 2023
@jorgepiloto jorgepiloto deleted the feat/update-pydata branch January 24, 2023 05:55
@germa89
Copy link
Contributor

germa89 commented Jan 26, 2023

Thank you guys! I can close now ansys/pymapdl#1756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@RobPasMue RobPasMue RobPasMue approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

Assignees
No one assigned
Labels
enhancement General improvements to existing features maintenance Generic maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to pydata-sphinx-theme==0.12.0.
5 participants
@Revathyvenugopal162 @jorgepiloto @RobPasMue @germa89 @MaxJPRey