Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: update theme to latest pydata-sphinx-theme layout #190

Merged
merged 15 commits into from
Feb 2, 2023
Merged

FEAT: update theme to latest pydata-sphinx-theme layout #190

merged 15 commits into from
Feb 2, 2023

Conversation

jorgepiloto
Copy link
Member

@jorgepiloto jorgepiloto commented Jan 31, 2023 •
edited
Loading

Fixes #189 by:

  • Replicating the structure seen in pydata-sphinx-theme to quickly identify overriden components.
  • Introducing a examples/ subpackage collecting samples and show cases.
  • Default HTML configuration is stablished in the __init__.py file.

@github-actions github-actions bot added enhancement General improvements to existing features documentation labels Jan 31, 2023
@github-actions github-actions bot added the maintenance Generic maintenance related label Feb 1, 2023
@jorgepiloto jorgepiloto force-pushed the feat/layout branch 2 times, most recently from 72a7f16 to e79bdc1 Compare February 1, 2023 08:56
@jorgepiloto jorgepiloto marked this pull request as ready for review February 1, 2023 14:41
jorgepiloto and others added 2 commits February 2, 2023 11:08
@jorgepiloto
FIX: remove blank line in theme.conf
361c7b9
@jorgepiloto @Revathyvenugopal162
FIX: remove unused html_logo variable
ecfb969 
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
RobPasMue
RobPasMue approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Some minor comments only - feel free to disregard.

pyproject.toml Show resolved Hide resolved
@jorgepiloto jorgepiloto merged commit 21f74e4 into main Feb 2, 2023
@jorgepiloto jorgepiloto deleted the feat/layout branch February 2, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@Revathyvenugopal162 Revathyvenugopal162 Revathyvenugopal162 approved these changes

@MaxJPRey MaxJPRey Awaiting requested review from MaxJPRey

Assignees
No one assigned
Labels
enhancement General improvements to existing features maintenance Generic maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove outdated HTML files in favor of new ones.
3 participants
@jorgepiloto @RobPasMue @Revathyvenugopal162